Re: Replication server timeout patch

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Replication server timeout patch
Date: 2011-03-30 08:08:22
Message-ID: AANLkTi=5NUBKzToWAiYGAZqXW2GnbbbA0hUbxr6pBwJw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 30, 2011 at 5:03 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> On 30.03.2011 10:58, Fujii Masao wrote:
>>
>> On Wed, Mar 30, 2011 at 4:24 PM, Heikki Linnakangas
>> <heikki(dot)linnakangas(at)enterprisedb(dot)com>  wrote:
>> +        A value of zero means wait forever.  This parameter can only be
>> set in
>>
>> The first sentence sounds misleading. Even if you set the parameter to
>> zero,
>> replication connections can be terminated because of keepalive or socket
>> error.
>
> Hmm, should I change it back to "A value of zero disables the timeout" ? Any
> better suggestions?

I like that. But I appreciate if anyone suggests the better.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2011-03-30 08:12:27 Re: Problem with streaming replication, backups, and recovery (9.0.x)
Previous Message Heikki Linnakangas 2011-03-30 08:03:33 Re: Replication server timeout patch