Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags

On Sat, Dec 11, 2010 at 17:23, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Sat, Dec 11, 2010 at 17:13, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Ah, I have a theory: <fcntl.h>.
>
>> Nope, not there. I can't find S_IWGRP in any of the files.
>
> Well, I notice that copydir.c compiled before, and still compiles after,
> despite this change:
>
> -   if (mkdir(todir, S_IRUSR | S_IWUSR | S_IXUSR) != 0)
> +   if (mkdir(todir, S_IRWXU) != 0)
>
> I think the reason it's not failing is that it includes <fcntl.h>.

S_IRWXU is defined in port/win32.h...

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/