Re: including backend ID in relpath of temp rels - updated patch

From: Jaime Casanova <jaime(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: including backend ID in relpath of temp rels - updated patch
Date: 2010-07-29 06:56:16
Message-ID: AANLkTi=0+4bESnqXPmvWRQUCvrVyVH3G5C15NjyCb35P@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jul 25, 2010 at 4:32 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Sun, Jul 25, 2010 at 2:37 AM, Jaime Casanova <jaime(at)2ndquadrant(dot)com> wrote:
>> but i have a few questions, maybe is right what you did i only want to
>> understand it:
>> - you added this in include/storage/smgr.h, so why is safe to assume
>> that if the backend != InvalidBackendId it must be a temp relation?
>>
>> +#define SmgrIsTemp(smgr) \
>> +   ((smgr)->smgr_rnode.backend != InvalidBackendId)
>
> That's pretty much the whole point of the patch.  Instead of
> identifying relations as simply "temporary" or "not temporary", we
> identify as "a temporary relation owned by backend X" or as "not
> temporary".
>

Ok, this one seems good enough... i'm marking it as "ready for committer"

--
Jaime Casanova         www.2ndQuadrant.com
Soporte y capacitación de PostgreSQL

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2010-07-29 08:58:24 Re: page corruption on 8.3+ that makes it to standby
Previous Message Florian Pflug 2010-07-29 01:23:51 Re: Patch to show individual statement latencies in pgbench output