It looks good to me: (0) new patch applies cleanly to CVS HEAD; (1)
the formating of the code was changed; (2) definition of the HYPOT
macro was changed to use phypot rather than being removed; (3) the
phypot function was declared to be extern; (4) the comments to the
phypot function were changed to remove the reference about the SUS
I changed the status to "Ready for Committer".
On Fri, Jul 23, 2010 at 4:01 PM, Kevin Grittner
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I think the patch is good in principle
> Since everyone seems to agree this is a good patch which needed
> minor tweaks, and we haven't heard from the author, I just went
> ahead and made the changes.
> Andrew, could you take another look and see if you agree I've
> covered it all before it gets marked ready for a committer?
In response to
pgsql-hackers by date
|Next:||From: Yeb Havinga||Date: 2010-07-24 12:17:51|
|Subject: Re: Review of Synchronous Replication patches|
|Previous:||From: Guillaume Lelarge||Date: 2010-07-24 10:21:23|
|Subject: Re: antisocial things you can do in git (but not CVS)|