Skip site navigation (1) Skip section navigation (2)

Re: win32 setitimer implementation

From: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>
To: 'Magnus Hagander' <mha(at)sollentuna(dot)net>,pgsql-patches(at)postgresql(dot)org, pgsql-hackers-win32(at)postgresql(dot)org
Subject: Re: win32 setitimer implementation
Date: 2004-02-17 11:24:40
Message-ID: A02DEC4D1073D611BAE8525405FCCE2B55F2FD@harris.memetrics.local (view raw or flat)
Thread:
Lists: pgsql-hackers-win32pgsql-patches


> Here is a patch that implements setitimer() on win32. With this patch
> applied, deadlock detection and statement_timeout now works.
> 
> The file timer.c goes into src/backend/port/win32/.

Minor comments:

* "timer.c" has shmem.c in header
* I'd suggest Asserts on the remaining 2 limitations ("zero" it_interval and
NULL ovalue), on the off chance that some future change to the source
expects them (ie. so we'll find out about it under win32 pretty quickly);
possibly provide defines of ITIMER_VIRT and ITIMER_PROF, for completeness.

Looks good,
Claudio

--- 
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see 
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>

pgsql-patches by date

Next:From: Magnus HaganderDate: 2004-02-17 21:03:35
Subject: Re: win32 setitimer implementation
Previous:From: Neil ConwayDate: 2004-02-17 09:08:33
Subject: Re: Repost: Linking references in documentation

pgsql-hackers-win32 by date

Next:From: Magnus HaganderDate: 2004-02-17 14:34:40
Subject: Re: win32 setitimer implementation
Previous:From: Bruce MomjianDate: 2004-02-17 03:47:44
Subject: Re: Updated win32 readdir patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group