Skip site navigation (1) Skip section navigation (2)

Re: win32 signals, part 4

From: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>
To: 'Magnus Hagander' <mha(at)sollentuna(dot)net>,pgsql-patches(at)postgresql(dot)org
Cc: pgsql-hackers-win32 <pgsql-hackers-win32(at)postgresql(dot)org>,Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>
Subject: Re: win32 signals, part 4
Date: 2004-02-05 01:17:41
Message-ID: A02DEC4D1073D611BAE8525405FCCE2B55F2D7@harris.memetrics.local (view raw or flat)
Thread:
Lists: pgsql-hackers-win32pgsql-patches
> >If there are no further comments from Claudio or anyone else, I feel
> >this is now ready to be applied.

Code walkthrough looks good.

One final minor point to discuss: 
	Is being unable to set a handler for things like CTRL_C_EVENT,
CTRL_SHUTDOWN_EVENT etc really a non-fatal error? ISTM that, if we can't
guarantee to cleanly handle externally generated signals (like a shutdown
request) or those that could occur internally (like, say, SIGFPE, which I'm
guessing you'll get to), then we probably ought to bail.

Either way, I agree that we ought to get this patch in as is.

Cheers,
Claudio

--- 
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see 
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>

pgsql-patches by date

Next:From: Jan WieckDate: 2004-02-05 01:31:08
Subject: Re: [PATCHES] win32 signals, part 4
Previous:From: Gaetano MendolaDate: 2004-02-05 00:20:56
Subject: Re: pg_generate_sequence and info_schema patch (Was: SELECT

pgsql-hackers-win32 by date

Next:From: Jan WieckDate: 2004-02-05 01:31:08
Subject: Re: [PATCHES] win32 signals, part 4
Previous:From: Tom LaneDate: 2004-02-04 23:38:18
Subject: Re: pqsignal - to be or (in this case) not to be

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group