Under Win32, localtime returns NULL for dates pre 1970.
A number of places in the code fail to check from a NULL return from
localtime, with none seemingly more problematic than those calls within
DetermineLocalTimeZone, which causes SEGVs in a number of tests (which
clearly pass pre 1970 dates to this function).
If we want to support pre-1970 dates, which I imagine we do, then this
function requires some serious rework under Win32. If we don't, then I'm
guessing we can just drop in some error checking for a NULL return from
localtime (as I've done on my personal source base), and modify the tests
for Win32 accordingly.
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see
pgsql-hackers by date
|Next:||From: Tom Lane||Date: 2004-02-02 06:57:15|
|Subject: Re: [HACKERS] Pre-1970 dates under Win32 |
|Previous:||From: Christopher Kings-Lynne||Date: 2004-02-02 04:53:30|
|Subject: Re: Idea about better configuration options for sort memory|
pgsql-hackers-win32 by date
|Next:||From: Korea PostgreSQL Users' Group||Date: 2004-02-02 05:58:35|
|Subject: CVS source win32 mingw some comile error|
|Previous:||From: Korea PostgreSQL Users' Group||Date: 2004-02-02 05:19:43|
|Subject: CVS source win32 mingw some comile error |