Skip site navigation (1) Skip section navigation (2)

Re: Win32 signals code, take two

From: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>
To: 'Magnus Hagander' <mha(at)sollentuna(dot)net>,pgsql-hackers-win32 <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: Win32 signals code, take two
Date: 2004-01-19 13:03:09
Message-ID: A02DEC4D1073D611BAE8525405FCCE2B55F27F@harris.memetrics.local (view raw or flat)
Thread:
Lists: pgsql-hackers-win32
Hi Magnus,

I've only had time for a very superficial look, but looks good...

> * The signal listener threads now creates separate threads to read/write
> on the pipe, to make sure we don't hang anywhere there. I put the
> ReadFile() in the separate thread as well (to be sure). It 
> does not pose any different synchronisation issues than we had before.

Hmm, I'd be happier just seeing the main thread issue these calls, but no
firm argument as to why :-)


> Claudio, in your other working on the backend, have you by any chance
> identified good places to do:
> 1) pg_signal_initialize()?

I imagine we'll want to drop this main.c, right by the WSAStartup code.


> 2) PG_POLL_SIGNALS()?

Haven't had a chance to really try [sigh]. I promise to have a closer look,
at this and at your code, over the next couple days.

Talk soon,
Claudio

--- 
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see 
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>

pgsql-hackers-win32 by date

Next:From: Merlin MoncureDate: 2004-01-19 14:24:15
Subject: Re: Win32 signals code, take two
Previous:From: Magnus HaganderDate: 2004-01-18 16:15:02
Subject: Win32 signals code, take two

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group