Re: BUG #5339: Version of Perl detected incorrectly

From: Jonathan Leto <jonathan(at)leto(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alex Hunsaker <badalex(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #5339: Version of Perl detected incorrectly
Date: 2010-02-22 20:14:53
Message-ID: 9aaadf9c1002221214j704e0e45q647832f407ab278@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Howdy,

On Mon, Feb 22, 2010 at 12:07 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alex Hunsaker <badalex(at)gmail(dot)com> writes:
>> On Mon, Feb 22, 2010 at 10:57, Jonathan <jonathan(at)leto(dot)net> wrote:
>>> This is perl 5, version 11, subversion 4 (v5.11.4-114-ga4cc961*) built for
>>> x86_64-linux
>
> Ugh.  Can't they manage to keep that message reasonably consistent?

The form of the version string is the closest release version
(5.11.4), the number of commits ahead of that (114) and the SHA1 of
the actual commit. What flavor of consistency are you looking for?

>
>> !   perl_version_error=`$PERL -e 'use 5.00801;' 2>&1`
>
> This is not a path towards an acceptable solution, as it effectively
> assumes what we are setting out to prove, namely that we have found
> a reasonably modern version of perl.  Try it in perl 4...

These words don't seem to make sense. Can you translate? The the code
that Tim suggested is the most succinct way to ask Perl if it is at
least a certain minimum version, instead of inspecting the output of
"perl -v" and performing voodoo.

>
>                        regards, tom lane
>

In short, +1 to Tim's suggestion.

--
Jonathan "Duke" Leto
jonathan(at)leto(dot)net
http://leto.net

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Jaime Casanova 2010-02-22 20:21:20 Re: BUG #5340: Requirement of different syntax on different OS
Previous Message Tom Lane 2010-02-22 20:07:50 Re: BUG #5339: Version of Perl detected incorrectly