Skip site navigation (1) Skip section navigation (2)

Re: suggested warning about perl nested named subroutines

From: "Greg Sabino Mullane" <greg(at)turnstep(dot)com>
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: suggested warning about perl nested named subroutines
Date: 2005-10-23 21:36:59
Message-ID: 9a9a8e6128e6dc6c156b9c4745b71241@biglumber.com (view raw or flat)
Thread:
Lists: pgsql-patches
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


>>One more annoyance, while I'm here: what's with "spi_exec_query()"? Is that
>>the best name we could come up with? How about something short and simple,
>>in the same vein as "elog()", such as "sql()" ? :)

> I don't much like it either. But it's there from 8.0, so we really
> shouldn't change it now. OTOH I don't like also having spi_query, but
> nobody has kicked up much. If we're going to change that we need to
> change it real fast.

We don't need to change it and break backwards-compatibilty, but we could
easily add in a synonym and deprecate spi_*. I prefer sql() or exec(),
although the latter is a little to close to "EXECUTE". Maybe do() in
the spirit of DBI (although it returns result sets, so that could be
potentially confusing). Other ideas? I'm assuming this is a 8.2 thing,
so we have plenty of time. :)

- --
Greg Sabino Mullane greg(at)turnstep(dot)com
PGP Key: 0x14964AC8 200510231734
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8

-----BEGIN PGP SIGNATURE-----

iD8DBQFDXAJBvJuQZxSWSsgRAs5qAJ9xcw/lcEcOsD3gBcc6o6xQcC4HTgCeNhKQ
aofyqUREbX0jYJD+CVY3FQI=
=1XDK
-----END PGP SIGNATURE-----



In response to

pgsql-patches by date

Next:From: Greg Sabino MullaneDate: 2005-10-23 21:47:19
Subject: Another small pl/perl patch
Previous:From: Martijn van OosterhoutDate: 2005-10-22 19:42:27
Subject: [PATCH] Fix Ctrl-C related issues in psql (not for 8.1)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group