Re: [HACKERS] Interval aggregate regression failure

From: Michael Glaesemann <grzm(at)seespotcode(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paesold <mpaesold(at)gmx(dot)at>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Interval aggregate regression failure
Date: 2006-09-05 11:58:11
Message-ID: 9F275769-399A-4397-B40B-9F414C07C687@seespotcode.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


On Sep 5, 2006, at 10:14 , Bruce Momjian wrote:

> Bruce Momjian wrote:
>> OK, updated patch. It will fix the >=24:00:00 case because it
>> cascades
>> up if the remainder number of seconds is greater or equal to one day.
>> One open item is that it still might show >24 hours if the seconds
>> computation combined with the remaning seconds >24 hours. Not
>> sure if
>> that should be handled or not. If you fix that, you really are
>> cascading up because the resulting seconds might be less than the
>> computed value, e.g. result is 23:00:00, remainder is 02:00:00,
>> cascade
>> up would be 1 day, 01:00:00. I am unsure we want to do that. Right
>> now, this will show 25:00:00.
>
> Updated patch that uses TSROUND for partial month and days. Michael
> says the tests look good on his system. I think we are done with this
> bug. :-)

Please find attached regression tests for this patch.

Michael Glaesemann
grzm seespotcode net

Attachment Content-Type Size
17interval_muldiv_0905T2053+0900.diff application/octet-stream 4.1 KB
unknown_filename text/plain 1 byte

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2006-09-05 12:01:22 Re: Open items for 8.2
Previous Message Michael Glaesemann 2006-09-05 11:22:04 Re: Fix PGPORT reassignment in ecpg regression tests