RE: Re: Cygwin PostgreSQL postmaster abort problem

> > > Note that this file is no longer needed with current
> Cygwin releases.
> > > Cygwin provides its own "DllMain" now. May be a
> compromise would be to
> > > have make check the Cygwin version and eliminate
> dllinit.c from the
> > > build if it is not necessary. I am willing to submit
> such a patch if it
> > > was deemed reasonable.
> >
> > Sounds great to me. Maybe the
> CYGWIN_VERSION_API_MAJOR/MINOR symbols
> > could be used to #ifdef out the entire dllinit.c if not
> needed? (A more
> > "correct" approach would probably be to check for the existance of
> > DllMain, but I'm not sure if you/we are up to that at this point.)
>
> Can I assume that dllinit.c is only used by Cygwin (i.e, not
> by straight

Yes, it is used only by Cygwin.

> Win32)? If so, then I can surround the contents with:
>
> #include <cygwin/version.h>
> #if CYGWIN_VERSION_DLL_MAJOR < 1001
> ...
> #endif /* CYGWIN_VERSION_DLL_MAJOR */

I think that better will be to use CYGWIN_VERSION_API_MAJOR and
..._MINOR. These numbers depend on changes in the library that have
influence for other applications.

>
> Otherwise, this part of the patch is going to get ugly.

Dan