Skip site navigation (1) Skip section navigation (2)

Re: --enable-odbc issue for Darwin/Mac OS X

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Ronald Guest <ronald(at)pepsan(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: --enable-odbc issue for Darwin/Mac OS X
Date: 2000-12-18 02:05:34
Message-ID: 9956.977105134@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Ronald Guest <ronald(at)pepsan(dot)com> writes:
> /* Ignore malloc.h if we have STDC_HEADERS */
> #if defined(HAVE_MALLOC_H) && !defined(STDC_HEADERS)
> #       include <malloc.h>
> #endif

I'd vote for ripping those includes out altogether.  No other part of
our sources needs <malloc.h>, and I don't believe ODBC does or should
either.

In a larger sense, the ODBC driver is probably not nearly as portable
as the rest of Postgres, because it hasn't gotten wrung out on as many
platforms.  Maybe we ought to start compiling it by default (not for
7.1 though ;-)).

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Katsuyuki TanakaDate: 2000-12-18 13:41:48
Subject: jdbc connectint ot db
Previous:From: Ronald GuestDate: 2000-12-18 01:47:06
Subject: --enable-odbc issue for Darwin/Mac OS X

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group