Re: Re: [COMMITTERS] pgsql: Remove old-style VACUUM FULL (which was known for a little while

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Remove old-style VACUUM FULL (which was known for a little while
Date: 2010-02-11 15:55:28
Message-ID: 9881.1265903728@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> This would only happen if a VACUUM FULL had been run on the pre-9.0
> database and it had failed part way through.

If that were true, you might have an argument, but it isn't. VACUUM
FULL was never very careful about getting rid of all MOVED_xxx bits.
See the comments for update_hint_bits().

> We should remove the moved in/off flag bits and make it a part of the
> upgrade process to ensure the absence of those states.

That's not happening. The whole point of upgrade in place is to not do
anything as expensive as a full-database scan.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-02-11 16:27:38 Re: Re: [COMMITTERS] pgsql: Remove old-style VACUUM FULL (which was known for a little while
Previous Message Euler Taveira de Oliveira 2010-02-11 15:29:38 Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexey Klyukin 2010-02-11 16:10:30 a common place for pl/perlu modules
Previous Message Robert Haas 2010-02-11 15:53:22 Re: Writeable CTEs and empty relations