Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Define INADDR_NONE on Solaris when it's missing.

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Define INADDR_NONE on Solaris when it's missing.
Date: 2010-02-02 19:10:26
Message-ID: 9837222c1002021110i7864d5catd42ca670baa93110@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
2010/2/1 Magnus Hagander <magnus(at)hagander(dot)net>:
> 2010/1/28 Magnus Hagander <magnus(at)hagander(dot)net>:
>> On Thu, Jan 28, 2010 at 21:16, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>>> On Thu, Jan 28, 2010 at 17:16, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>>>> However, now that I know the real issue is you're using inet_addr, I
>>>>> would like to know why you're not using inet_aton instead; or even
>>>>> better, something that also copes with IPv6.
>>>
>>>> "Path of least resistance?"
>>>
>>>> Which method would you suggest?
>>>
>>> I haven't actually read the RADIUS patch, but generally we rely on
>>> pg_getaddrinfo_all to interpret strings representing IP addresses.
>>> Is there a reason not to use that?
>>
>> I don't think so. I'll look it over.
>
> Here's what I came up with. Works well on the platforms I've tried,
> but I haven't tried on a non-ipv6 capable one yet (need to find one..)
> I'll also remove the defines from solaris.h when applying it.

Applied with some adjustments needed for non-ipv6 platforms.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-02-02 19:16:17
Subject: Re: New VACUUM FULL crashes on temp relations
Previous:From: Andres FreundDate: 2010-02-02 19:08:12
Subject: Re: [HACKERS] Re: Faster CREATE DATABASE by delaying fsync (was 8.4.1 ubuntu karmic slow createdb)

pgsql-committers by date

Next:From: Tom LaneDate: 2010-02-02 19:12:29
Subject: pgsql: CLUSTER specified the wrong namespace when renaming toast tables
Previous:From: Magnus HaganderDate: 2010-02-02 19:09:37
Subject: pgsql: Make RADIUS authentication use pg_getaddrinfo_all() to get

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group