Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Define INADDR_NONE on Solaris when it's missing.

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Define INADDR_NONE on Solaris when it's missing.
Date: 2010-01-28 20:19:34
Message-ID: 9837222c1001281219n19384ae7k26fe0283395982e9@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Thu, Jan 28, 2010 at 21:16, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Thu, Jan 28, 2010 at 17:16, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> However, now that I know the real issue is you're using inet_addr, I
>>> would like to know why you're not using inet_aton instead; or even
>>> better, something that also copes with IPv6.
>
>> "Path of least resistance?"
>
>> Which method would you suggest?
>
> I haven't actually read the RADIUS patch, but generally we rely on
> pg_getaddrinfo_all to interpret strings representing IP addresses.
> Is there a reason not to use that?

I don't think so. I'll look it over.


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2010-01-28 20:56:04
Subject: remove contrib/xml2
Previous:From: Tom LaneDate: 2010-01-28 20:16:24
Subject: Re: pgsql: Define INADDR_NONE on Solaris when it's missing.

pgsql-committers by date

Next:From: Andrew DunstanDate: 2010-01-28 23:06:09
Subject: pgsql: Fix bug found by warning from recent gcc.
Previous:From: Tom LaneDate: 2010-01-28 20:16:24
Subject: Re: pgsql: Define INADDR_NONE on Solaris when it's missing.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group