Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Define INADDR_NONE on Solaris when it's missing.

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Define INADDR_NONE on Solaris when it's missing.
Date: 2010-01-28 15:53:44
Message-ID: 9837222c1001280753x4cc1ec89h3d63784eac05938b@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Thu, Jan 28, 2010 at 16:46, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> mha(at)postgresql(dot)org (Magnus Hagander) writes:
>> Log Message:
>> -----------
>> Define INADDR_NONE on Solaris when it's missing. Per a couple of buildfarm
>> members complaining.
>
> This seems likely to break as much as it fixes, since there's no very
> good reason to assume that whatever header should define INADDR_NONE
> has been included before the os.h header file has been read.

Hmm. Where would you suggest it goes?

The addition of such a define is in a lot of places on the net as
fixing just this issue, and was also recommended by Zdenek as the fix
for Solaris. But I can agree it may be in the wrong place :-)

> Possibly more to the point, where are we using INADDR_NONE anyway?

In the RADIUS code.


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2010-01-28 15:56:45
Subject: Re: Review: listagg aggregate
Previous:From: Tom LaneDate: 2010-01-28 15:48:53
Subject: Re: Streaming replication, and walsender during recovery

pgsql-committers by date

Next:From: Tom LaneDate: 2010-01-28 16:04:37
Subject: Re: pgsql: Define INADDR_NONE on Solaris when it's missing.
Previous:From: Tom LaneDate: 2010-01-28 15:46:47
Subject: Re: pgsql: Define INADDR_NONE on Solaris when it's missing.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group