Re: [PATCH] Windows x64 [repost]

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tsutomu Yamada <tsutomu(at)sraoss(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Windows x64 [repost]
Date: 2010-01-04 17:28:57
Message-ID: 9837222c1001040928l25ad44b6xdc520b0b172d2930@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 1, 2010 at 20:45, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada <tsutomu(at)sraoss(dot)co(dot)jp> wrote:
>>
>> 2) use appropriate macro and datatypes for Windows API.
>>   enables more than 32bits shared memory.
>
> Are you sure this one should use __noop, and not __nop?
>
> __noop: http://msdn.microsoft.com/en-us/library/s6btaxcs.aspx
> __nop: http://msdn.microsoft.com/en-us/library/aa983381.aspx
>
> I think __nop is what we want?
>
> Also, that turns it into "nop" and not "rep nop", no?

I did some more research, and __nop() is at least closer than
__noop(), but it's still not the same.

> Should we perhaps instead use __yield, per:
> http://msdn.microsoft.com/en-us/library/2b2h26kx.aspx

On further reading, __yield() is only available on Itanium.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2010-01-04 18:05:48 Re: pg_migrator issues
Previous Message Hitoshi Harada 2010-01-04 17:20:07 Re: More frame options in window functions