Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Windows x64 [repost]

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tsutomu Yamada <tsutomu(at)sraoss(dot)co(dot)jp>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Windows x64 [repost]
Date: 2009-12-30 23:30:36
Message-ID: 9837222c0912301530v7c01f3c7g1b9f9877c1aa4a4d@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
2009/12/4 Tsutomu Yamada <tsutomu(at)sraoss(dot)co(dot)jp>:
> Thanks to suggestion.
> I send pathces again by another mailer for the archive.
>
> Sorry to waste resources, below is same content that I send before.

I have a couple of comments about the first patch (I'll get to the
others later):

config.win32.h has:
+ #ifdef _MSC_VER
+ /* #undef HAVE_STDINT_H */
+ #else
  #define HAVE_STDINT_H 1
+ #endif

Is that really necessary? config.h.win32 is only used on MSVC builds, no?

A bit further down, it has:

+ /* The size of `void *', as computed by sizeof. */
+ #define SIZEOF_VOID_P 4
+


shouldn't that be 8 for win64 platforms?

This patch also needs autoconf support for other platforms, but I've
bugged Bruce about that and have some code to get that done. Just
wanted these questions settled before I move on.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

pgsql-hackers by date

Next:From: Andres FreundDate: 2009-12-30 23:43:52
Subject: Re: Hot Standy introduced problem with query cancel behavior
Previous:From: Bruce MomjianDate: 2009-12-30 23:26:10
Subject: Re: Allowing x IS NOT NULL as a btree search condition

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group