Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] pgsql: /home/peter/commit-msg

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: David Fetter <david(at)fetter(dot)org>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)postgresql(dot)org
Subject: Re: [HACKERS] pgsql: /home/peter/commit-msg
Date: 2009-11-16 07:44:05
Message-ID: 9837222c0911152344n77de0d73s61c0dc331a51ab0@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Mon, Nov 16, 2009 at 08:29, David Fetter <david(at)fetter(dot)org> wrote:
> On Mon, Nov 16, 2009 at 06:56:54AM +0200, Peter Eisentraut wrote:
>> On sön, 2009-11-15 at 17:09 -0500, Tom Lane wrote:
>> > David Fetter <david(at)fetter(dot)org> writes:
>> > > On Sun, Nov 15, 2009 at 10:09:14AM -0500, Andrew Dunstan wrote:
>> > >> Peter Eisentraut wrote:
>> > >>> /home/peter/commit-msg
>> > >> er, what?
>> > > I'm suspecting a misfired script somewhere.
>> >
>> > No doubt "cvs commit -m ~/commit-msg" instead of "cvs commit -F ~/commit-msg"
>> > ... I think I've made that mistake too.
>> >
>> > For the sake of the archives: it was the previously proposed fix for
>> > bug #5075, see
>> > http://archives.postgresql.org/pgsql-bugs/2009-11/msg00131.php
>>
>> Yeah, sorry guys.  I fixed the CVS log message now.
>
> Strangely, the git repo still shows the old message.  For the record,
> there's the new one:

I don't find that strange at all.

In git, the commit message is part of the commit, and thus the SHA1.

If it changes, it would be a different commit. Which would change
history and break the repositories of anybody pulling from it.

So it's not only not strange, I'm very happy it didn't pull those
changes and broke my repository :-)


Now, if we want to "correct" that the way to do it is to rebuild the
git mirror from scratch and have everybody start over, I think :-)
While you're not supposed to change history in any RCS, git makes it a
lot harder than cvs to do it...

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

pgsql-hackers by date

Next:From: Simon RiggsDate: 2009-11-16 07:59:22
Subject: Re: Summary and Plan for Hot Standby
Previous:From: David FetterDate: 2009-11-16 07:29:12
Subject: Re: [HACKERS] pgsql: /home/peter/commit-msg

pgsql-committers by date

Next:From: Heikki LinnakangasDate: 2009-11-16 08:05:58
Subject: Re: [HACKERS] pgsql: /home/peter/commit-msg
Previous:From: David FetterDate: 2009-11-16 07:29:12
Subject: Re: [HACKERS] pgsql: /home/peter/commit-msg

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group