Skip site navigation (1) Skip section navigation (2)

Re: BUG #4961: pg_standby.exe crashes with no args

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: wader2 <wader2(at)jcom(dot)home(dot)ne(dot)jp>
Cc: pgsql-bugs(at)postgresql(dot)org, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: BUG #4961: pg_standby.exe crashes with no args
Date: 2009-08-10 18:10:24
Message-ID: 9837222c0908101110n6dc607beq2651006205f79f22@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers
On Mon, Aug 10, 2009 at 16:10, wader2<wader2(at)jcom(dot)home(dot)ne(dot)jp> wrote:
> Bruce Momjian wrote:
>>
>> I can't reproduce a crash here on BSD:
>>
>>        $ pg_standby
>>        pg_standby: not enough command-line arguments
>>
>> Can you show us the command and the crash text?
>
> I guess this occurs on only windows (Japanese envionment?).
>
> C:\Program Files\PostgreSQL\8.4\bin>pg_standby.exe
>
> results no text on command line, Windows error dialog.
>
> AppName:pg_standby.exe AppVer:0.0.0.0 ModName:msvcr80.dll
> ModVer:8.0.50727.762   Offset:000091ad

I have reproduced this. The problem is:
	(void) signal(SIGUSR1, sighandler);
	(void) signal(SIGINT, sighandler);	/* deprecated, use SIGUSR1 */


None of these signals exist on WIN32. I think the only reason it
compiles at all is that we bring in *some* of our signals emulation
code, but certainly not all of it.

If I just move those two lines into the #ifndef WIN32 block just
around it, it compiles and doesn't crash on running-with-no-arguments.
I haven't tried to actually use it though - can someone confirm if
this will actually make pg_standby not work properly?

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2009-08-10 18:31:12
Subject: Re: WIP: to_char, support for EEEE format
Previous:From: Brendan JurdDate: 2009-08-10 17:56:08
Subject: Re: WIP: to_char, support for EEEE format

pgsql-bugs by date

Next:From: Bruce MomjianDate: 2009-08-10 18:21:07
Subject: Re: BUG #4965: missing tests in tools/fsync/test_fsync.c
Previous:From: Hiroshi SaitoDate: 2009-08-10 16:19:40
Subject: Re: BUG #4961: pg_standby.exe crashes with no args

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group