Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Reserve the shared memory region during backend startup on

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Reserve the shared memory region during backend startup on
Date: 2009-08-05 12:38:27
Message-ID: 9837222c0908050538m2667ca13hd134539ca4f82413@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Tue, Jul 28, 2009 at 15:45, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Mon, Jul 27, 2009 at 16:14, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I'm not really insisting on a redesign.  I'm talking about the places
>>> where the code author appears not to have understood that ERROR means
>>> FATAL, because the code keeps plugging on after it anyway.  As far as
>>> I can see, using ERROR at lines 3630, 3657, 3674, and 3693 is just
>>> plain bogus, and changing to LOG there requires no other fixing.
>
>> But. I'll look into cleaning those up for HEAD anyway, but due to lack
>> of reports I think we should skip backpatch. Reasonable?
>
> Fair enough.

Here's what I came up with. Seems ok?


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Attachment: exec_errors.patch
Description: text/x-diff (7.7 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Michael MeskesDate: 2009-08-05 13:02:13
Subject: Re: status of ECPG patches?
Previous:From: Robert HaasDate: 2009-08-05 12:08:02
Subject: status of ECPG patches?

pgsql-committers by date

Next:From: Alvaro HerreraDate: 2009-08-05 13:12:57
Subject: Re: Re: [COMMITTERS] pgsql: Use DocBook XSL stylesheets for man page building This switches
Previous:From: Michael MeskesDate: 2009-08-05 11:42:20
Subject: pgsql: Fixed copyright notice.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group