Skip site navigation (1) Skip section navigation (2)

Re: Moving snapshot code around

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Neil Conway <neilc(at)samurai(dot)com>, Pg Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Moving snapshot code around
Date: 2008-03-26 18:17:25
Message-ID: 980.1206555445@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Tom Lane wrote:
>> I'd have gone with snapmgr.h/c for consistency with existing filenames
>> (bufmgr, lmgr, etc).

> Doh!  Sorry.  We're at the best time for changing the name, since the
> file has no history.  Shall I?

+1

>> I don't like that very much.  What about just moving the HTSU_Result
>> enum's declaration somewhere else?  Two possibilities are heapam.h
>> itself, or the new snapshot.h file (which'd then have to be included
>> by heapam.h, but it seems lightweight enough that that's not too
>> terrible).

> Well, heapam.h includes a lot of other headers, so it doesn't look a
> good candidate to me.  I think snapshot.h is a reasonably good
> candidate.

Works for me.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2008-03-26 18:23:02
Subject: Re: Auto Partitioning Patch - WIP version 1
Previous:From: Bruce MomjianDate: 2008-03-26 18:14:00
Subject: Re: Auto Partitioning Patch - WIP version 1

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group