Re: PATCH: CITEXT 2.0 v3

From: "David E(dot) Wheeler" <david(at)kineticode(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: PATCH: CITEXT 2.0 v3
Date: 2008-07-15 05:09:27
Message-ID: 97D27121-AAF8-4FDB-86A9-8D6716323E62@kineticode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Jul 14, 2008, at 07:08, Tom Lane wrote:

> You're really making it into another test. Just copy the citext.sql
> file into the sql/ subdirectory and add a "citext" entry to the
> schedule
> file.
>
> The last time I did this, I had to at least "touch" a corresponding
> expected file (expected/citext.out) or pg_regress would go belly-up
> without running the rest of the tests. There's no special need to
> make the expected file match, of course, since you can just ignore
> the "failure" report from that one test.

Okay, I copied citext.sql into src/test/regress/sql and then added
"test: citext" to the top of src/test/regress/serial_schedule. Then I
ran `make check`. All tests passed, but I don't think that citext was
tested.

Do I need to install the server, build a cluster, and run `make
installcheck`?

Thanks for the hand-holding.

Best,

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message ITAGAKI Takahiro 2008-07-15 07:25:46 Re: [PATCHES] WIP: executor_hook for pg_stat_statements
Previous Message Greg Smith 2008-07-15 05:07:28 Re: posix advises ...