Re: Tablespace patch review

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Tablespace patch review
Date: 2004-06-19 05:10:35
Message-ID: 9721.1087621835@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> I should think that the table-level display ought to show both the
>> relfilenode and tablespace OIDs for each table.

> For objects in the default tablespace, they don't show a tablespace oid,
> right? Where do we put it? A column that will be empty if they don't
> use tablespaces?

pg_class will show a zero for objects in the default tablespace, but
I think oid2name should pull the actual tablespace ID from
pg_database.dattablespace and show that. The convention about zero
is just to make life simple for CREATE DATABASE --- users of oid2name
should not have to think about it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2004-06-19 05:17:34 Re: Tablespace patch review
Previous Message Tom Lane 2004-06-19 05:04:32 Re: Minor DROP TABLESPACE issue

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-06-19 05:13:55 Re: eventlog fix
Previous Message Tom Lane 2004-06-19 05:02:22 Re: Tablespace patch review