Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> Tom Lane wrote:
>> As far as the ugliness in XLogRecordPageWithFreeSpace goes: couldn't you
>> just call XLogReadBufferWithFork with init = true, and then initialize
>> the page if PageIsNew?
> With init=true, we don't even try to read the page from the disk (since
> 8.3), so all FSM pages accessed during recovery would be zeroed out. I
> don't think that's what you intended.
Ah, right. Maybe the API change you suggested in the comment is the
way to go.
regards, tom lane