Skip site navigation (1) Skip section navigation (2)

contrib/ intarray, ltree, intagg broken(?) by array changes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>,Teodor Sigaev <teodor(at)stack(dot)net>, mlw <markw(at)mohawksoft(dot)com>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: contrib/ intarray, ltree, intagg broken(?) by array changes
Date: 2002-08-26 18:37:47
Message-ID: 963.1030387067@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Joe Conway and I have just committed some changes in the internal
representation of Postgres arrays: an element-type-OID field is added to
the array header, and alignment calculations are now done the same way
as in ordinary tuple storage, instead of taking shortcuts.  I believe
that these changes need to be reflected into the intarray, ltree, and
intagg contrib modules.

intarray and ltree both seem to be mapping their own declarations onto
arrays using largely-similar code.  But while intarray fails its
regression test, I find ltree still passes.  So I'm confused about what
that code is really doing and don't want to touch it.

I tried to fix intagg, but since there is no regression test for it
I'm unsure whether it's okay.

Could you folks take a look at CVS tip and see what changes are needed,
if any?

In the longer run, it might be possible to improve these routines to be
array-type-polymorphic using the new features.  But with the 7.3 beta
date nearly upon us, I'd counsel first making the existing functionality
work again...

			regards, tom lane

Responses

pgsql-hackers by date

Next:From: Lamar OwenDate: 2002-08-26 18:40:54
Subject: Re: @(#)Mordred Labs advisory 0x0007: Remove DoS in PostgreSQL
Previous:From: cbbrowneDate: 2002-08-26 18:34:02
Subject: How To Make Things Appear More Dramatic

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group