Skip site navigation (1) Skip section navigation (2)

Re: [GENERAL] pgstattuple triggered checkpoint failure and database outage?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Stuart Bishop <stuart(at)stuartbishop(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [GENERAL] pgstattuple triggered checkpoint failure and database outage?
Date: 2009-03-31 14:35:54
Message-ID: 9598.1238510154@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-generalpgsql-hackers
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Tom Lane wrote:
>> I can't remember having seen bugs of this type before.

> If we had had this defense in place, it would have been obvious that
> reindex and cluster were buggy.  The code to skip temp tables was not
> there from the beginning.

I thought my memory was probably failing me (excuse: no caffeine yet).

> (We already have rel->rd_istemp, but it's not what we need here.)

Yeah.  I was considering converting that into a three-state flag, but
it might be simpler to remove it altogether and look to the new pg_class
field; only after we've gone down the path into localbuf.c would we
check relnamespace == our temp namespace before permitting a read or write.

Barring objections, I'll go make that happen.  (And fix the contrib bugs
too, but not till after ... I'll need a test case ;-))

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Sam MasonDate: 2009-03-31 14:42:56
Subject: Re: [HACKERS] string_to_array with empty input
Previous:From: Alvaro HerreraDate: 2009-03-31 14:26:20
Subject: Re: [GENERAL] pgstattuple triggered checkpoint failureand database outage?

pgsql-general by date

Next:From: Sam MasonDate: 2009-03-31 14:42:56
Subject: Re: [HACKERS] string_to_array with empty input
Previous:From: Alvaro HerreraDate: 2009-03-31 14:26:20
Subject: Re: [GENERAL] pgstattuple triggered checkpoint failureand database outage?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group