Re: SVN Commit by guillaume: r8145 - in trunk/pgadmin3: . pgadmin/db pgadmin/frm

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: SVN Commit by guillaume: r8145 - in trunk/pgadmin3: . pgadmin/db pgadmin/frm
Date: 2009-12-30 12:53:12
Message-ID: 937d27e10912300453r3e14da30mca3e0e79b1718d53@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Sorry - I didn't get a chance to actually look at this patch until now.

The application_name should be set as a connection string parameter,
not an explicit SET command. This ensures that the application name is
included in the initial connection log message, and avoids a round
trip with the SET query. PQconninfoParse can be used to test if libpq
supports application_name at runtime.

I suspect the patch is also missing some changes to the debugger.

On Tue, Dec 29, 2009 at 5:39 PM, <svn(at)pgadmin(dot)org> wrote:
> Author: guillaume
>
> Date: 2009-12-29 17:39:36 +0000 (Tue, 29 Dec 2009)
>
> New Revision: 8145
>
> Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=8145&view=rev
>
> Log:
> Use application_name for each window.
> Add support of the new application_name column in activity report (8.5).
> (fixes ticket #116)
>
>
> Modified:
>   trunk/pgadmin3/CHANGELOG
>   trunk/pgadmin3/pgadmin/db/pgConn.cpp
>   trunk/pgadmin3/pgadmin/frm/frmConfig.cpp
>   trunk/pgadmin3/pgadmin/frm/frmEditGrid.cpp
>   trunk/pgadmin3/pgadmin/frm/frmHbaConfig.cpp
>   trunk/pgadmin3/pgadmin/frm/frmMainConfig.cpp
>   trunk/pgadmin3/pgadmin/frm/frmQuery.cpp
>   trunk/pgadmin3/pgadmin/frm/frmStatus.cpp
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2009-12-30 13:14:53 Re: SVN Commit by guillaume: r8145 - in trunk/pgadmin3: . pgadmin/db pgadmin/frm
Previous Message pgAdmin Trac 2009-12-30 09:31:31 [pgAdmin III] #121: Filtering available columns in the edit grid