Skip site navigation (1) Skip section navigation (2)

Re: [GENERAL] CREATE TABLE LIKE and SERIAL

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: [GENERAL] CREATE TABLE LIKE and SERIAL
Date: 2009-11-12 09:12:00
Message-ID: 937d27e10911120112q49fe8061uf29688451a4ed034@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackerspgsql-general
On Thu, Nov 12, 2009 at 8:00 AM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Le dimanche 1 novembre 2009 à 13:24:10, Dave Page a écrit :
>> On Fri, Oct 30, 2009 at 11:12 PM, Guillaume Lelarge
>>
>> <guillaume(at)lelarge(dot)info> wrote:
>> > Le vendredi 30 octobre 2009 à 23:48:45, Tom Lane a écrit :
>> >> Thom Brown <thombrown(at)gmail(dot)com> writes:
>> >> > How is pgAdmin determining the serial type in this case?
>> >>
>> >> Most likely it's looking for the pg_depend entry that shows the sequence
>> >> as being "owned by" the column.  However, that's an oversimplification
>> >> of reality.  I would imagine that pgAdmin will lie to you in exactly
>> >> the same cases that used to break pg_dump (notably, where someone has
>> >> manually adjusted either the default expression or the sequence...)
>> >
>> > I've just read this. I wasn't aware of this. Should we suppress this
>> > behavior of pgAdmin?
>>
>> Do you have a proposed fix? I suspect people won't want us to stop
>> showing columns as 'SERIAL' when they actually were created that way.
>>
>
> Other ideas than doing what pg_dump does? I'm afraid not.

pg_dump isn't designed to make the output look pretty, which is the
major issue here. We're trying to do both.

It seems to me that correctness trumps aesthetics, so we probably will
have to do what pg_dump does. Care to work up a patch?

-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

In response to

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2009-11-13 07:32:20
Subject: Re: [GENERAL] CREATE TABLE LIKE and SERIAL
Previous:From: Guillaume LelargeDate: 2009-11-12 08:00:58
Subject: Re: [GENERAL] CREATE TABLE LIKE and SERIAL

pgsql-general by date

Next:From: Koen MartensDate: 2009-11-12 09:13:26
Subject: Re: pgday.eu
Previous:From: Dave PageDate: 2009-11-12 08:47:51
Subject: Re: pgday.eu

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group