Skip site navigation (1) Skip section navigation (2)

Re: pgAdmin and Slony

From: Dave Page <dave(dot)page(at)enterprisedb(dot)com>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: Sachin Srivastava <sachin(dot)srivastava(at)enterprisedb(dot)com>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgAdmin and Slony
Date: 2009-09-30 12:23:22
Message-ID: 937d27e10909300523kd064357x84ec6be4e196e814@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
Ashesh - did you get a chance to test this?

On Thu, Sep 3, 2009 at 2:37 PM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> Looks good to me..
> Though not tested..
> I will be able to test it tomorrow.
>
> Dave Page wrote:
>
> On Thu, Sep 3, 2009 at 2:08 PM, Sachin
> Srivastava<sachin(dot)srivastava(at)enterprisedb(dot)com> wrote:
>
> Dave,
>
> - bool dlgRepCluster::SlonyMaximumVersion(wxString series, long minor)
>
> should be:
>
> bool dlgRepCluster::SlonyMaximumVersion(const wxString&series, long minor)
>
> Done.
>
> - Just reading the patch, it looks like we never try to load xxid*.sql
> any more. That's surely wrong?
>
> Yes. Attached is an updated patch.
>
> Thanks. I've had a quick look, and it looks reasonable to me. Ashesh;
> can you review it as well please?
>
>



-- 
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

In response to

Responses

pgadmin-hackers by date

Next:From: Ashesh VashiDate: 2009-09-30 13:03:54
Subject: Re: pgAdmin and Slony
Previous:From: svnDate: 2009-09-30 11:53:34
Subject: SVN Commit by dpage: r8055 - branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group