Re: It seems to miss PQclear function

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Quan Zongliang <quanzongliang(at)gmail(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: It seems to miss PQclear function
Date: 2009-09-16 09:53:53
Message-ID: 937d27e10909160253j794db60aqaf0d71756dc38d64@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Yup, looks that way. Patch applied.

Thanks!

On Tue, Sep 15, 2009 at 6:08 AM, Quan Zongliang <quanzongliang(at)gmail(dot)com> wrote:
> hi all
>
> In ExecuteVoid function of pgConn class:
>    // Check for errors
>    if (lastResultStatus != PGRES_TUPLES_OK &&
>        lastResultStatus != PGRES_COMMAND_OK)
>    {
>        LogError(!reportError);
>        return false;
>    }
>
> Shoud be:
>    // Check for errors
>    if (lastResultStatus != PGRES_TUPLES_OK &&
>        lastResultStatus != PGRES_COMMAND_OK)
>    {
>        LogError(!reportError);
>        PQclear(qryRes);
>        return false;
>    }
>
> right?
>
>
> -----------------------------------------------
> Quan Zongliang
> quanzongliang(at)gmail(dot)com
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Rudi Schmitz 2009-09-16 17:47:33 Desktop and xpm file in Centos 5 compile
Previous Message svn 2009-09-16 09:53:09 SVN Commit by dpage: r8036 - branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/db