Skip site navigation (1) Skip section navigation (2)

Re: Second l10n patch

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org, Marek Černocký <marek(at)manet(dot)cz>
Subject: Re: Second l10n patch
Date: 2009-08-03 11:04:34
Message-ID: 937d27e10908030404q2e67e375ycc9ad3415e440ebf@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
2009/8/3 Guillaume Lelarge <guillaume(at)lelarge(dot)info>:
> Le lundi 3 août 2009 à 12:33:56, Guillaume Lelarge a écrit :
>> Le lundi 3 août 2009 à 11:57:02, Dave Page a écrit :
>> > 2009/8/1 Marek Černocký <marek(at)manet(dot)cz>:
>> > > Hi,
>> > >
>> > > I send patch. It solves translation for object type names in reports.
>> >
>> > Should code like this use wxPLURAL?
>> >
>> > int section = report->XmlCreateSection(wxString::Format(_("%s
>> > dependents"), object->GetTranslatedTypeName().c_str()));
>>
>> No. We need wxPLURAL when we have a variable that tells us if it is plural
>> or not. In this code, there's nothing that gives us a hint about it.
>>
>> Note that I didn't actually try this patch. Only read it.
>
> Just tried it, and it works the way I think it should. I can commit it if you
> want.

Sure - thanks.


-- 
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

In response to

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2009-08-03 11:10:17
Subject: Re: Change: l10n patch
Previous:From: Guillaume LelargeDate: 2009-08-03 11:03:39
Subject: Re: Second l10n patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group