Re: need more reviewers for index changes

On 7/21/09, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Jul 21, 2009 at 6:40 AM, Stephen Frost<sfrost(at)snowman(dot)net> wrote:
>> Robert,
>>
>> * Robert Haas (robertmhaas(at)gmail(dot)com) wrote:
>>> It probably makes sense to start with indexam api changes, since the
>>> other one depends on that one.
>>
>> I've looked the patch over, but the problem is that the patch doesn't do
>> terribly much by itself, and Tom's already commented on things he
>> doesn't like about it. Alot of the patch here:
>> http://archives.postgresql.org/message-id/4A5ADFE6.6060507@enterprisedb.com
>> is changing heap_hot_search_buffer to have heapTuple passed in as a
>> pointer rather than a local var, which makes for many '.' to '->'
>> changes. The rest is just splitting index_getnext into two pieces.
>
> Ah, yes, I see your point. So I think this is actually waiting on
> author. We should poke Heikki.

I believe he's on vacation.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com