Skip site navigation (1) Skip section navigation (2)

Re: Bug in SQL editor find and replace

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, David Blewett <david(at)dawninglight(dot)net>, pgadmin-support(at)postgresql(dot)org
Subject: Re: Bug in SQL editor find and replace
Date: 2009-06-24 09:12:47
Message-ID: 937d27e10906240212k215f18b8l85895e09776dfbb4@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-support
On Wed, Jun 24, 2009 at 10:07 AM, Andres Freund<andres(at)anarazel(dot)de> wrote:
> On 06/24/2009 10:35 AM, Dave Page wrote:
>>
>> On Tue, Jun 23, 2009 at 8:23 PM, Andres Freund<andres(at)anarazel(dot)de>  wrote:
>>
>>> I found the issue. The code compares '(unsigned int)(-1)' with
>>> '(size_t)(-1)' which works on 32bit but not on 64bit.
>>
>> Thanks Andres - patch applied.
>
> I havent read very much of the code, but at a very quick glance a short
> policing for issues of this kind looks sensible - unfortunately I cant do
> this in due time (I think I have spotted some more comparisons of this kind
> - I am not sure how big the influence of those is though).

Yeah, that certainly wouldn't hurt. If you spot anything in passing,
please point it out.

We're not going to get a full review done before release now anyway...


-- 
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

In response to

Responses

pgadmin-support by date

Next:From: Andres FreundDate: 2009-06-24 09:45:11
Subject: Re: Bug in SQL editor find and replace
Previous:From: Andres FreundDate: 2009-06-24 09:07:55
Subject: Re: Bug in SQL editor find and replace

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group