Skip site navigation (1) Skip section navigation (2)

Re: PATCH: ctlSQLBox format-menu for indent/outdent, change lower/upper case & comment/uncomment for the selected text

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: ctlSQLBox format-menu for indent/outdent, change lower/upper case & comment/uncomment for the selected text
Date: 2009-03-19 16:12:10
Message-ID: 937d27e10903190912gf2b96das20a06dab50bce719@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Thu, Mar 19, 2009 at 3:50 PM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi Team,
>
> Please find the patch for the above description.
>
> As per Dave's suggestion, I have added format submenu in the edit menu.
> Just move the code for the indent/outdent to BlockIndent function & for
> commet/uncomment to BlockComment function. And called these function from
> the event function for the format menus and from the ctlSQLBox::OnKeyDown
> function, from where it has been moved.

Thanks Ashesh.

Hackers; Ashesh worked up this patch in response to a suggestion from
Ray O'Donnell that we should add the new editing features to a menu on
the query tool to help the users learn them. I think I should have
done that in the first place, and wanted to see how invasive the patch
was, and whether we should apply it during beta.

I think it's OK. Can I get some other opinions please? Otherwise I'll
apply tomorrow.


-- 
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

In response to

Responses

pgadmin-hackers by date

Next:From: Magnus HaganderDate: 2009-03-19 18:35:53
Subject: Re: Re: PATCH: ctlSQLBox format-menu for indent/outdent, change lower/upper case & comment/uncomment for the selected text
Previous:From: Ashesh VashiDate: 2009-03-19 15:50:27
Subject: PATCH: ctlSQLBox format-menu for indent/outdent, change lower/upper case & comment/uncomment for the selected text

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group