Skip site navigation (1) Skip section navigation (2)

Re: Server Status window work

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Server Status window work
Date: 2009-02-02 14:09:54
Message-ID: 937d27e10902020609p6df5473u2746ba6d2c1e6256@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Thu, Jan 29, 2009 at 10:40 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:

> So here is the next one. I fixed a few issues, added some more comments,
> moved some code to get something easy to read, and used the four timers.
> It seems to be working right on my laptop. I did a quick check on
> Windows and it was working all right too.

Hi,

There are a few issues immediately apparent:

- There's debug code in checkConnection

- MNU_REFRESH/OnRefresh() seem redundant now.

- The default size of the dialog is tall and thin - if I so much as
touch the resize corner it doubles in width to a more sensible size.
Observed on Windows.

- You need a lock to prevent the four refresh functions running
simultaneously and doing nasty things to the connection. You should
probably use a wxCriticalSectionLocker.

- It looks like we still refresh each tab even if it's not visible (or
even closed). We should check that to minimise the database traffic.

- If a tab is closed and re-opened (from the View menu), it returns to
it's default position on the tabset, not to whereever it previously
was.

- The tab layout is not remembered if the window is closed and reopened.


-- 
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

In response to

Responses

pgadmin-hackers by date

Next:From: Quan ZongliangDate: 2009-02-03 03:21:22
Subject: Import: ODBC page design
Previous:From: Dave PageDate: 2009-02-02 13:53:13
Subject: Any artists out there?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group