Skip site navigation (1) Skip section navigation (2)

Re: Patch : "Change the panel in tabs was setting the top switches to SQL Editor"

From: "Dave Page" <dpage(at)pgadmin(dot)org>
To: "Ashesh Vashi" <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch : "Change the panel in tabs was setting the top switches to SQL Editor"
Date: 2008-12-04 11:18:18
Message-ID: 937d27e10812040318x122af38etd83fc1033c97c36e@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Thu, Dec 4, 2008 at 10:36 AM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi Dave Page,
>>
>> I think - this is a bug from a while, I can reproduce the same for the
>> "Criteria Panel".
>> If I make any changes in the "Criteria Panel", and then click "Columns
>> Panel", the main
>> tab set at the top switches to "SQL Editor". :(
>>
>> I will send a patch for it.
>
> As I have told you, this was a bug introduced earlier.
> The object sqlNoteBook (in frmQuery class) and the object tabs (in the
> gqbController class)
> both were using the same id (CTL_NTBKCENTER).
> And in frmQuery class, an event handler - OnChangeNotebook is registered
> with this id.
>
> I changed the id for the object tabs of gqbController to CTL_NTBKPANELS.
>
> Please find the patch for the same.

thanks - patch applied.


-- 
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

In response to

pgadmin-hackers by date

Next:From: svnDate: 2008-12-04 11:52:54
Subject: SVN Commit by dpage: r7509 - trunk/pgadmin3/pgadmin/frm
Previous:From: svnDate: 2008-12-04 11:17:51
Subject: SVN Commit by dpage: r7508 - trunk/pgadmin3/pgadmin/gqb

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group