On Mon, Nov 17, 2008 at 10:00 AM, Quan Zongliang
>> The case of the text should follow existing cases as well - if a label
> In fact, NULLS order's default value is different base of DESC.
> When create index:
> If DESC is specified, default is NULLS FIRST.
> If not (ASC, default), default is NULLS LAST.
> So, I think if there is only FIRST and LAST. Maybe it confuse user.
> Suggest me, pls.
That's a good point. I think we should remove the default option, so
the user can choose explicitly - but, if the user (un)chooses DESC,
then the appropriate default should be automatically selected.
>> The DESC checkbox doesn't align horizontally with the combo box to its left.
> Like this: ?
> Column <column's combobox>
> DESC <checkbox>
> NULLS <Default FIRST LAST>
> Add Remove
That would work. At the moment, the DESCK checkbox is a few pixels too
low which looks odd.
>> The columns list view doesn't size correctly when the form is opened
>> on Mac
> Yes, new method dlgIndex::OnChangeSize() is needed.
> I have not Mac, can't test.
No problem. Guillaume and I have Macs and one of us can help out.
> About TODO item:
> Allow Sequence to be attached to existing int4/int8 columns
> It means to make sequence dialog can support the "OWNED BY" clause in
> "CREATE/ALTER SEQUENCE" statement?
That's part of it. I think the TODO item is intended as something that
will be done on dlgColumn though.
EnterpriseDB UK: http://www.enterprisedb.com
In response to
pgadmin-hackers by date
|Next:||From: svn||Date: 2008-11-17 11:09:26|
|Subject: SVN Commit by dpage: r7499 - trunk/pgadmin3/pgadmin/db|
|Previous:||From: Quan Zongliang||Date: 2008-11-17 10:00:39|
|Subject: Re: the patch: support for DESC/NULLS FIRST/NULLS LAST|