On Thu, Nov 6, 2008 at 11:15 PM, Guillaume Lelarge
> Still a hack but it works. It even works with GTK. The patch attached
> removes the WXMAC ifdef.
>>> I also found on Windows that the check boxes for different privileges
>>> on the privilege panes are touching each other and could use some
>>> spacing. Can you look at that please?
> I forgot to add a border to the checkboxes. I tried from 4 to 1. 4 was
> really big. I still hesitate between 1 et 2. 2 seems better, so that's
> the value in the patch. I think you should try both of them and tell us
> which one you prefer.
Hmm, I think they still look a little close. After some
experimentation, I'd say 3 or 4 on Windows, and 3 on Mac - but it
could use a few additional px between the combo and the top checkbox.
If you can add that, I'd say go with 3.
New bug: The definition pane on dlgFunction is thoroughly broken when
working with C functions :-(. I think this just got overlooked when
you redrew everything.
I'm happy for you to apply when you're happy. Things are definitely
going in the right direction!
EnterpriseDB UK: http://www.enterprisedb.com
In response to
pgadmin-hackers by date
|Next:||From: Quan Zongliang||Date: 2008-11-15 05:57:15|
|Subject: Re: bug report|
|Previous:||From: Guillaume Lelarge||Date: 2008-11-14 21:40:44|
|Subject: Re: Patch for ALTER DATABASE|