Skip site navigation (1) Skip section navigation (2)

Re: Patch for removing TipsOfDay functionality

From: "Dave Page" <dpage(at)pgadmin(dot)org>
To: "Ashesh D Vashi" <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Patch for removing TipsOfDay functionality
Date: 2008-11-04 12:08:06
Message-ID: 937d27e10811040408k7f58ec1cu5d633c5e25b5709a@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Tue, Nov 4, 2008 at 6:02 AM, Ashesh D Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi,
>
> As per Dave page suggestion, I worked on removing the "Tips Of the Day"
> functionality.
> I have attached the patch for it.
>
> Please review it.

Hi Ashesh,

An eyeball review looks good - you've fixed up a couple of places I'd
completely forgotten about. Just one change required I think; in the
Windows installer part of the patch, there are a bunch of hunks like:

                                 <Component Id="de_de_docs"
Guid="{BCC51FC8-18F9-46CB-A536-8EB8A55812F0}">
-                                    <File Id="de_de_docs.tips.txt"
Name="tips.txt" DiskId="1"
Source="$(var.BUILDTREE)/docs/de_DE/tips.txt" />
+                                    <CreateFolder/>
                                 </Component>

We should just remove those empty components altogether I think.

-- 
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

In response to

Responses

pgadmin-hackers by date

Next:From: svnDate: 2008-11-04 15:04:14
Subject: SVN Commit by dpage: r7496 - in trunk/pgadmin3: . docs docs/de_DE docs/en_US docs/es_ES docs/fi_FI docs/fr_FR docs/it_IT docs/sl_SI docs/zh_CN docs/zh_TW pgadmin pgadmin/frm pgadmin/include/frm pgadmin/include/utils pgadmin/utils pkg/win32/src
Previous:From: Ashesh D VashiDate: 2008-11-04 11:02:23
Subject: Patch for removing TipsOfDay functionality

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group