Re: Buglets in dlgFunction

From: "Dave Page" <dpage(at)pgadmin(dot)org>
To: "Guillaume Lelarge" <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Buglets in dlgFunction
Date: 2008-10-27 13:23:46
Message-ID: 937d27e10810270623t5a768520s686889ea703a6b7e@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Sun, Oct 19, 2008 at 10:33 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Thanks. I still don't like this hack. I hope I'll soon better understand
> this issue to replace the ugly code with a good one.

You're going to hate this - but I just tested Gevik's work on Windows,
and seem to be seeing the SQL and Privilege panes mis-behaving there
:-(

I wonder if we just need to defer the restoration of the dialogue size
to a much later time than it currently is done. Obviously we could
just do it at the point that you have your hack at the moment, but it
would be nice to do it in the base class. I tried doing this quickly
but didn't get too far. Putting your existing hack towards the end of
dlgProperty::Go (but without the WXMAC ifdef) seemed to do the job
though - albeit still hackily.

Thoughts?

I also found on Windows that the check boxes for different privileges
on the privilege panes are touching each other and could use some
spacing. Can you look at that please?

Thanks.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2008-10-27 13:40:58 Re: Patch for Index stat
Previous Message Dave Page 2008-10-27 12:37:23 Re: extending functionality strategy