Skip site navigation (1) Skip section navigation (2)

Re: Buglets in dlgFunction

From: "Dave Page" <dpage(at)pgadmin(dot)org>
To: "Guillaume Lelarge" <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Buglets in dlgFunction
Date: 2008-10-02 08:53:39
Message-ID: 937d27e10810020153i75e92c4fq4c44f8d57f6b0f26@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Thu, Oct 2, 2008 at 12:05 AM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Dave Page a écrit :
>> [...]
>> I found a couple of small bugs in the new layout code for dlgFunction:
>>
>> - The Privileges (and SQL) panes don't size themselves properly when
>> viewing an existing function, until the dialogue is manually resized
>> - The privilege checkboxes are touching the role combo box above.
>>
>> I've attached a screenshot for your amusement :-)
>>
>
> I finally found some time to work on this... You'll find a patch
> attached. It seems to work nice on Mac and Linux. Can you check on your
> Mac ? Thanks.
>
> I would love this to be the solution. This hack would allow us to get
> rid of the 350 constant in the OnSize method.

Testing dlgFunction:

The SQL pane seems OK now, but the privileges pane opens with the
controls at a minimal size on the parent pane, and the listview still
has the non-shrinking bug :-(. I've attached screenshots.

Testing dlgTable, dlgSequence:

(create mode) SQL pane is fine. Initial size of the privileges
controls are fine, just the listview bug remaining. (edit mode)
pgAdmin crashes.

Testing dlgDatabase:

SQL pane is fine. Initial size of the privileges controls are fine,
just the listview bug remaining.

Testing dlgPackage:

SQL pane is fine. Initial sizing of the privilege controls is broken.
The listview bug is not present.

Testing dlgTablespace, dlgSchema, dlgView:

Work perfectly :-)

So it seems like all bugs are fixed somewhere, just not on all dialogues!

-- 
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

Attachment: Picture 2.png
Description: image/png (74.5 KB)
Attachment: Picture 1.png
Description: image/png (76.5 KB)

In response to

Responses

pgadmin-hackers by date

Next:From: Robert TreatDate: 2008-10-02 16:12:46
Subject: Re: [HACKERS] Function management in PG
Previous:From: Guillaume LelargeDate: 2008-10-01 23:05:59
Subject: Re: Buglets in dlgFunction

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group