Skip site navigation (1) Skip section navigation (2)

Re: Enabling SQL text field in the SQL tab of object dialog

From: "Dave Page" <dpage(at)postgresql(dot)org>
To: "Guillaume Lelarge" <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Enabling SQL text field in the SQL tab of object dialog
Date: 2008-08-26 19:54:45
Message-ID: 937d27e10808261254h90b92f5t4c39e1391e1c687@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Tue, Aug 26, 2008 at 6:48 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Guillaume Lelarge a écrit :
>> [...]
>> Back on this. The plan took a lot more time than I initially thought.
>> Anyways, here is the v5 patch updated.
>>
>
> I'm tired for sure... here is the patch.

:-(

Well it looks good (you've *really* got the hang of XRC/wxSizers now
:-) ) - but if I open the 'New Database' dialogue, enter a name, and
then click on the SQL tab, I get an assert on OSX.

Thread 0 Crashed:
0   libSystem.B.dylib             	0x95dd4b9e __kill + 10
1   libSystem.B.dylib             	0x95e4bec2 raise + 26
2   ...x_base_carbonud-2.8.0.dylib	0x014f7f84 wxTrap() + 18
3   libwx_macud_core-2.8.0.dylib  	0x00f11912
wxGUIAppTraitsBase::ShowAssertDialog(wxString const&) + 254
4   ...x_base_carbonud-2.8.0.dylib	0x014f84f2 ShowAssertDialog(wchar_t
const*, int, wchar_t const*, wchar_t const*, wchar_t const*,
wxAppTraits*) + 412
5   ...x_base_carbonud-2.8.0.dylib	0x014f87aa
wxAppConsole::OnAssertFailure(wchar_t const*, int, wchar_t const*,
wchar_t const*, wchar_t const*) + 60
6   ...x_base_carbonud-2.8.0.dylib	0x014f862c wxOnAssert(wchar_t
const*, int, char const*, wchar_t const*, wchar_t const*) + 232
7   libwx_macud_core-2.8.0.dylib  	0x00e67149
wxChoice::GetString(unsigned int) const + 97
8   libwx_macud_core-2.8.0.dylib  	0x00e69da4 wxComboBox::GetValue() const + 116
9   pgAdmin3-Debug                	0x000973be dlgDatabase::GetSql() +
4312 (dlgDatabase.cpp:472)
10  pgAdmin3-Debug                	0x000ca42d
dlgProperty::FillSQLTextfield() + 383 (dlgProperty.cpp:616)
11  pgAdmin3-Debug                	0x000cbc9e
dlgProperty::OnPageSelect(wxNotebookEvent&) + 138
(dlgProperty.cpp:925)
<snip>

I also get a crash if I try to open the New Table dialogue. I suspect
that is the possible incompatibility that you were worried about,
though I guess it could be related to this patch.

Thread 0 Crashed:
0   pgAdmin3-Debug                	0x000197e3
wxStringBase::GetStringData() const + 9 (string.h:265)
1   ...x_base_carbonud-2.8.0.dylib	0x01564239
wxArrayString::Add(wxString const&, unsigned long) + 259
2   ...x_base_carbonud-2.8.0.dylib	0x0156435a
wxArrayString::Copy(wxArrayString const&) + 88
3   ...x_base_carbonud-2.8.0.dylib	0x0156463c
wxArrayString::operator=(wxArrayString const&) + 44
4   pgAdmin3-Debug                	0x000486c2
ctlSecurityPanel::GetGrant(wxString const&, wxString const&,
wxArrayString*) + 52 (ctlSecurityPanel.cpp:155)
5   pgAdmin3-Debug                	0x000d3359
dlgSecurityProperty::GetGrant(wxString const&, wxString const&) + 71
(dlgProperty.cpp:1606)
6   pgAdmin3-Debug                	0x000f612a dlgTable::GetSql() +
27284 (dlgTable.cpp:849)
7   pgAdmin3-Debug                	0x000fb36c dlgTable::CheckChange()
+ 166 (dlgTable.cpp:985)
8   pgAdmin3-Debug                	0x000ca26c
dlgProperty::OnChange(wxCommandEvent&) + 26 (dlgProperty.cpp:550)
9   pgAdmin3-Debug                	0x000f7013
dlgTable::OnChangeVacuum(wxCommandEvent&) + 2651 (dlgTable.cpp:958)
10  pgAdmin3-Debug                	0x000fad5a dlgTable::Go(bool) +
15678 (dlgTable.cpp:465)
11  pgAdmin3-Debug                	0x000cc6e1
dlgProperty::EditObjectDialog(frmMain*, ctlSQLBox*, pgObject*) + 707
(dlgProperty.cpp:1082)
12  pgAdmin3-Debug                	0x000d5203
propertyFactory::StartDialog(frmMain*, pgObject*) + 41
(dlgProperty.cpp:1784)
13  pgAdmin3-Debug                	0x0011b463
frmMain::OnAction(wxCommandEvent&) + 95 (events.cpp:147)

-- 
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

In response to

Responses

pgadmin-hackers by date

Next:From: svnDate: 2008-08-26 21:37:27
Subject: SVN Commit by guillaume: r7421 - trunk/pgadmin3/pgadmin/dlg
Previous:From: Guillaume LelargeDate: 2008-08-26 17:48:26
Subject: Re: Enabling SQL text field in the SQL tab of object dialog

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group