Skip site navigation (1) Skip section navigation (2)

Re: Support of INHERIT in existing tables (8.2+ releases)

From: "Dave Page" <dpage(at)pgadmin(dot)org>
To: "Guillaume Lelarge" <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Support of INHERIT in existing tables (8.2+ releases)
Date: 2008-08-11 12:53:18
Message-ID: 937d27e10808110553k421b0c96y6f34fc4152272c58@mail.gmail.com (view raw or flat)
Thread:
Lists: pgadmin-hackers
On Mon, Aug 11, 2008 at 1:50 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:

> There's already 4 fixes for an 1.8.5. And this one.
>
> Moreover, 1.10 is not expected before PostgreSQL 8.4 (march 2009 IIRC). I
> think it would be better to have another 1.8. Not now, but there's still
> like 7 months to go before next release. Not sure we won't need another
> minor release.

<grumble>We rarely release in the second-half of the PG cycle. Still,
go ahead and backpatch if you like.

>> The only thing that looks a little odd with this patch is that the Add
>> button is always enabled, even if there is no table selected. That is
>> actually the existing behaviour, but it's a little more obvious now
>> the button is enabled when editing existing tables as well. Should we
>> fix that? My gut feeling is yes.
>>
>
> hehe... I saw it but wasn't sure if I should work on that too :)
>
> Anyways, fixed.

Cool, thanks. I'm not going to review it again - please apply.

-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

In response to

Responses

pgadmin-hackers by date

Next:From: svnDate: 2008-08-11 13:01:25
Subject: SVN Commit by guillaume: r7398 - in trunk/pgadmin3: . pgadmin/dlg pgadmin/include/dlg pgadmin/include/schema pgadmin/schema
Previous:From: Guillaume LelargeDate: 2008-08-11 12:50:09
Subject: Re: Support of INHERIT in existing tables (8.2+ releases)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group