Skip site navigation (1) Skip section navigation (2)

Re: Exposing keywords to clients

From: "Dave Page" <dpage(at)pgadmin(dot)org>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Peter Eisentraut" <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>
Subject: Re: Exposing keywords to clients
Date: 2008-05-03 20:44:58
Message-ID: 937d27e10805031344n440e5ea5mbff6f5cda9d548f9@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-patches
On Sat, May 3, 2008 at 9:06 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Dave Page" <dpage(at)pgadmin(dot)org> writes:
> > Attached is an updated patch, giving the following output.
>
> Oh, one other thing: dropping externs into random modules unrelated to
> their source module is completely awful programming style, because there
> is nothing preventing incompatible declarations.  Put those externs in
> keywords.h instead.

OK.

> I suspect you have ignored a compiler warning
> about not declaring pg_get_keywords itself, too --- it should be
> extern'd in builtins.h.

No, no warning (I'm using VC++ today) - but fixed anyway.

Update attached, including corrected docs. Note to self - proof read
docs *after* putting the kids to bed in future.

-- 
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Attachment: pg_get_keywords-3.diff
Description: text/plain (7.5 KB)

In response to

Responses

pgsql-patches by date

Next:From: Andrew DunstanDate: 2008-05-03 23:35:37
Subject: Re: Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout
Previous:From: Tom LaneDate: 2008-05-03 20:06:54
Subject: Re: Exposing keywords to clients

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group