Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Including Snapshot Info with Indexes

From: "Gokulakannan Somasundaram" <gokul007(at)gmail(dot)com>
To: "Jonah H(dot) Harris" <jonah(dot)harris(at)gmail(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Including Snapshot Info with Indexes
Date: 2008-01-23 19:45:02
Message-ID: 9362e74e0801231145j59c4d47epe6080875645e6d4a@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Thanks for reviewing the patch. Please go ahead and make the changes and
re-submit the patch. I will take care, that i won't repeat the stated
mistakes again.

The Missing of Thick Keyword - i don't know how it got removed.



Thanks,
Gokul

On Jan 23, 2008 10:49 PM, Jonah H. Harris <jonah(dot)harris(at)gmail(dot)com> wrote:

> On Jan 23, 2008 11:28 AM, Gokulakannan Somasundaram <gokul007(at)gmail(dot)com>
> wrote:
> > Fixed a type 'o'....
>
> I'm playing with this now against 8.3 HEAD.  Looks like there's a
> couple things which are problematic:
>
> - DefineIndex was updated only in bootparse.c, not in bootparse.y
> - The patch contains changes to pg_config.h
> - THICK isn't defined in gram.y (as a token or under
> unreserved_keywords), so compilation of keywords.c fails.
>
> In the future, please make changes to the proper pre-built files so
> that someone doesn't have to configure it, then patch it.  I have them
> fixed and will submit the patch back here if you'd like.  Or, you can
> fix it.  It's up to you :)
>
> --
> Jonah H. Harris, Sr. Software Architect | phone: 732.331.1324
> EnterpriseDB Corporation                | fax: 732.331.1301
> 499 Thornall Street, 2nd Floor          | jonah(dot)harris(at)enterprisedb(dot)com
> Edison, NJ 08837                        | http://www.enterprisedb.com/
>

In response to

Responses

pgsql-hackers by date

Next:From: Gokulakannan SomasundaramDate: 2008-01-23 20:47:50
Subject: Re: autonomous transactions
Previous:From: Guillaume SmetDate: 2008-01-23 17:35:53
Subject: Re: Thick indexes - a look at count(1) query

pgsql-patches by date

Next:From: Jonah H. HarrisDate: 2008-01-23 21:19:18
Subject: Re: [HACKERS] Including Snapshot Info with Indexes
Previous:From: Magnus HaganderDate: 2008-01-23 19:13:59
Subject: Re: Compile of Test example is put into win32.mak of libpq.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group