Re: GUC option log_pid is not checked [Fwd: Bug#149675: Fix]

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Oliver Elphick <olly(at)lfix(dot)co(dot)uk>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: GUC option log_pid is not checked [Fwd: Bug#149675: Fix]
Date: 2002-06-12 14:12:31
Message-ID: 9350.1023891151@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Oliver Elphick <olly(at)lfix(dot)co(dot)uk> writes:
> The GUC option log_pid is not checked; LOG_PID is used by default,
> contrary to the documentation. This patch fixes it.

No it doesn't (at least not unless you are also going to propose closing
and reopening syslog at SIGHUP to deal with changes in log_pid setting).

I'm not convinced that there's anything wrong with the code anyway.
Do you expect log_timestamp to control whether timestamps are added to
syslog entries? If so you are out of luck. Perhaps we should just
tweak the documentation to make it clearer that log_pid and
log_timestamp only control the format of non-syslog logging.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-06-12 14:19:17 Re: WriteBuffer return value
Previous Message Manfred Koizar 2002-06-12 12:17:04 WriteBuffer return value