itagaki(at)postgresql(dot)org (Takahiro Itagaki) writes:
> Add psql tab completion for DO blocks.
> Also adjust documentation of DO.

This syntax synopsis is completely nuts:

DO { [ LANGUAGE <replaceable class="PARAMETER">lang_name</replaceable> ] | <replaceable class="PARAMETER">code</replaceable> } ...

It implies that an empty string is a valid substitute for the { ... }
construct, since I could take the first choice and then omit the
optional bracketed construct.

I think that it would be logically correct without the square brackets,
but as a matter of clarity I really doubt it's an improvement over the
original.

			regards, tom lane

In response to

• pgsql: Add psql tab completion for DO blocks. at 2010-02-15 02:55:01 from Takahiro Itagaki

Responses

• Re: [COMMITTERS] pgsql: Add psql tab completion for DO blocks. at 2010-02-15 09:27:12 from Takahiro Itagaki

pgsql-hackers by date

Next:	From: Fujii Masao	Date: 2010-02-15 06:45:03
	Subject: Re: Parameter name standby_mode
Previous:	From: Fujii Masao	Date: 2010-02-15 06:29:57
	Subject: Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL

pgsql-committers by date

Next:	From: Tom Lane	Date: 2010-02-15 06:57:19
	Subject: Re: [COMMITTERS] pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after
Previous:	From: Fujii Masao	Date: 2010-02-15 06:29:57
	Subject: Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL