Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Add psql tab completion for DO blocks.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: itagaki(at)postgresql(dot)org
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add psql tab completion for DO blocks.
Date: 2010-02-15 06:39:29
Message-ID: 9312.1266215969@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
itagaki(at)postgresql(dot)org (Takahiro Itagaki) writes:
> Add psql tab completion for DO blocks.
> Also adjust documentation of DO.

This syntax synopsis is completely nuts:

DO { [ LANGUAGE <replaceable class="PARAMETER">lang_name</replaceable> ] | <replaceable class="PARAMETER">code</replaceable> } ...

It implies that an empty string is a valid substitute for the { ... }
construct, since I could take the first choice and then omit the
optional bracketed construct.

I think that it would be logically correct without the square brackets,
but as a matter of clarity I really doubt it's an improvement over the
original.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Fujii MasaoDate: 2010-02-15 06:45:03
Subject: Re: Parameter name standby_mode
Previous:From: Fujii MasaoDate: 2010-02-15 06:29:57
Subject: Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL

pgsql-committers by date

Next:From: Tom LaneDate: 2010-02-15 06:57:19
Subject: Re: [COMMITTERS] pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after
Previous:From: Fujii MasaoDate: 2010-02-15 06:29:57
Subject: Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group