| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Lor <Robert(dot)Lor(at)Sun(dot)COM> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: DTrace probe patch for OS X Leopard |
| Date: | 2008-02-29 17:55:57 |
| Message-ID: | 9304.1204307757@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Robert Lor <Robert(dot)Lor(at)Sun(dot)COM> writes:
> I haven't heard any major disadvantages about keeping it in c.h, but if
> you are still adamant about keeping it out of c.h, I'll will go along
> with that.
I was thinking that pg_trace.h involved some backend-only code, but
I'm not sure why I thought that :-(. Yeah, your plan to do it by
restructuring the contents of pg_trace.h sounds fine.
We still have what I consider a big problem with the names of the
macros. Perhaps that could be fixed by passing the auto-generated
file through a sed script to put a prefix on the macro names before
we start to use it?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2008-02-29 18:24:52 | Re: CopyReadLineText optimization |
| Previous Message | Robert Lor | 2008-02-29 17:11:14 | Re: DTrace probe patch for OS X Leopard |